Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gopherbot: add the author of the change to the notification on github #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cmd/gopherbot: add the author of the change to the notification on github #20

wants to merge 2 commits into from
+5 −4

Conversation

codebien
Copy link

@codebien codebien commented Jun 12, 2019 •
edited
Loading

When a new change is pushed, the gopherbot posts a new message on Github following this new format:
Change https://golang.org/cl/NNNN by AUTHOR mentions this issue

A new method to the CL's API in the maintner package is added
to provide the related absolute url.

Fixes golang/go#26816

cmd/gopherbot, maintner: add the author of the change to the notifica…
590a834 
…tion on github

When a new change is pushed, the bot posts a message on Github following this new format:
Change https://golang.org/cl/NNNN by AUTHOR mentions this issue

A new method to the CL's API in the maintner package is added
to provide the related absolute url.

Fixes #26816
@gopherbot
Copy link
Contributor

This PR (HEAD: 590a834) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/181977 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

maintner: removed the cl url generator
ebf4772 
Restored the maintner file moving the cl url generator to the gopherbot logic as in the previous version.
@gopherbot
Copy link
Contributor

This PR (HEAD: ebf4772) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/181977 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/181977.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/build/cmd/gopherbot: add author to issue notification comments
3 participants
@codebien @gopherbot @googlebot